CCIP-4428 Decouple LiquidityManager tests with LockReleaseTokenPool (#…

…16017) * decouple LiquidityManager tests with LockReleaseTokenPool + Test Rename * split test files * [Bot] Update changeset file with jira issues * prettier run * liquiditymanager test refactor * reference events from interface / contracts + solidity version + spacing * prettier * remove duplicate events * prettier fix * fix * pretty --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
smartcontractkit · Jan 24, 2025 · 17a9e2a · 17a9e2a
1 parent d7f5497
commit 17a9e2a
Show file tree

Hide file tree

Showing 16 changed files with 556 additions and 525 deletions.
diff --git a/contracts/.changeset/five-brooms-knock.md b/contracts/.changeset/five-brooms-knock.md
@@ -0,0 +1,9 @@
+---
+'@chainlink/contracts': patch
+---
+
+#internal decouple LiquidityManager tests with LockReleaseTokenPool + Test Rename
+
+PR issue: CCIP-4428
+
+Solidity Review issue: CCIP-3966
diff --git a/contracts/gas-snapshots/liquiditymanager.gas-snapshot b/contracts/gas-snapshots/liquiditymanager.gas-snapshot
@@ -1,31 +1,17 @@
-LiquidityManager__report:test_EmptyReportReverts() (gas: 11181)
-LiquidityManager_addLiquidity:test_addLiquiditySuccess() (gas: 279198)
-LiquidityManager_rebalanceLiquidity:test_InsufficientLiquidityReverts() (gas: 206764)
-LiquidityManager_rebalanceLiquidity:test_InvalidRemoteChainReverts() (gas: 192374)
-LiquidityManager_rebalanceLiquidity:test_rebalanceBetweenPoolsSuccess() (gas: 9141798)
-LiquidityManager_rebalanceLiquidity:test_rebalanceBetweenPoolsSuccess_AlreadyFinalized() (gas: 9435757)
-LiquidityManager_rebalanceLiquidity:test_rebalanceBetweenPools_MultiStageFinalization() (gas: 9430897)
-LiquidityManager_rebalanceLiquidity:test_rebalanceBetweenPools_NativeRewrap() (gas: 9360730)
-LiquidityManager_rebalanceLiquidity:test_rebalanceLiquiditySuccess() (gas: 382928)
-LiquidityManager_receive:test_receive_success() (gas: 21182)
-LiquidityManager_removeLiquidity:test_InsufficientLiquidityReverts() (gas: 184959)
-LiquidityManager_removeLiquidity:test_OnlyFinanceRoleReverts() (gas: 10872)
-LiquidityManager_removeLiquidity:test_removeLiquiditySuccess() (gas: 236361)
-LiquidityManager_setCrossChainRebalancer:test_OnlyOwnerReverts() (gas: 17005)
-LiquidityManager_setCrossChainRebalancer:test_ZeroAddressReverts() (gas: 21669)
-LiquidityManager_setCrossChainRebalancer:test_ZeroChainSelectorReverts() (gas: 13099)
-LiquidityManager_setCrossChainRebalancer:test_setCrossChainRebalancerSuccess() (gas: 162186)
-LiquidityManager_setFinanceRole:test_OnlyOwnerReverts() (gas: 10987)
-LiquidityManager_setFinanceRole:test_setFinanceRoleSuccess() (gas: 21836)
-LiquidityManager_setLocalLiquidityContainer:test_OnlyOwnerReverts() (gas: 11030)
-LiquidityManager_setLocalLiquidityContainer:test_ReverstWhen_CalledWithTheZeroAddress() (gas: 10621)
-LiquidityManager_setLocalLiquidityContainer:test_setLocalLiquidityContainerSuccess() (gas: 3976150)
-LiquidityManager_setMinimumLiquidity:test_OnlyOwnerReverts() (gas: 10925)
-LiquidityManager_setMinimumLiquidity:test_setMinimumLiquiditySuccess() (gas: 36389)
-LiquidityManager_withdrawERC20:test_withdrawERC20Reverts() (gas: 180396)
-LiquidityManager_withdrawERC20:test_withdrawERC20Success() (gas: 205895)
-LiquidityManager_withdrawNative:test_OnlyFinanceRoleReverts() (gas: 13077)
-LiquidityManager_withdrawNative:test_withdrawNative_success() (gas: 51407)
+LiquidityManager_addLiquidity:test_addLiquidity() (gas: 280708)
+LiquidityManager_rebalanceLiquidity:test_rebalanceLiquidity() (gas: 380353)
+LiquidityManager_rebalanceLiquidity:test_rebalanceLiquidity_BetweenPools() (gas: 9141742)
+LiquidityManager_rebalanceLiquidity:test_rebalanceLiquidity_BetweenPools_AlreadyFinalized() (gas: 5843918)
+LiquidityManager_rebalanceLiquidity:test_rebalanceLiquidity_NativeRewrap() (gas: 5766947)
+LiquidityManager_rebalanceLiquidity:test_rebalanceLiquidity_RebalanceBetweenPoolsMultiStageFinalization() (gas: 5839103)
+LiquidityManager_receive:test_receive() (gas: 24490)
+LiquidityManager_removeLiquidity:test_removeLiquiditySuccess() (gas: 237114)
+LiquidityManager_setCrossChainRebalancer:test_setCrossChainRebalancer() (gas: 162164)
+LiquidityManager_setFinanceRole:test_setFinanceRole() (gas: 21792)
+LiquidityManager_setLocalLiquidityContainer:test_setLocalLiquidityContainer() (gas: 406009)
+LiquidityManager_setMinimumLiquidity:test_setMinimumLiquidity() (gas: 36433)
+LiquidityManager_withdrawERC20:test_withdrawERC20() (gas: 205876)
+LiquidityManager_withdrawNative:test_withdrawNative() (gas: 55522)
 OCR3Base_setOCR3Config:testFMustBePositiveReverts() (gas: 12245)
 OCR3Base_setOCR3Config:testFTooHighReverts() (gas: 12429)
 OCR3Base_setOCR3Config:testOracleOutOfRegisterReverts() (gas: 14847)

diff --git a/contracts/src/v0.8/liquiditymanager/test/LiquidityManager.addLiquidity.t.sol b/contracts/src/v0.8/liquiditymanager/test/LiquidityManager.addLiquidity.t.sol
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: BUSL-1.1
+pragma solidity ^0.8.24;
+
+import "./LiquidityManagerSetup.t.sol";
+import {LiquidityManager} from "../LiquidityManager.sol";
+
+contract LiquidityManager_addLiquidity is LiquidityManagerSetup {
+  function test_addLiquidity() external {
+    address caller = STRANGER;
+    changePrank(caller);
+
+    uint256 amount = 12345679;
+    deal(address(s_l1Token), caller, amount);
+
+    s_l1Token.approve(address(s_liquidityManager), amount);
+
+    vm.expectEmit();
+    emit LiquidityManager.LiquidityAddedToContainer(caller, amount);
+
+    s_liquidityManager.addLiquidity(amount);
+
+    assertEq(s_l1Token.balanceOf(address(s_lockReleaseTokenPool)), amount);
+  }
+}