bump solana + cleanup types #13253
Merged
bump solana + cleanup types #13253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
jmank88
reviewed
May 21, 2024
aalu1418
force-pushed
the
bump-solana-cleanup
branch
from
24f99fc to
f52b99f
Compare
jmank88
previously approved these changes
May 23, 2024
| err = multierr.Append(err, vc.ValidateConfig()) | ||
| for _, e := range utils.UnwrapError(vc.ValidateConfig()) { | ||
| err = multierr.Append(err, e) | ||
| } | ||
| } else if v.CanAddr() { | ||
| i = v.Addr().Interface() | ||
| if vc, ok := i.(Validated); ok { |
There was a problem hiding this comment.
I think this one needs to be aligned with the previous case. Maybe we don't have coverage for it?
There was a problem hiding this comment.
yeah I don't think there's test coverage on it since adding/removing it didn't do anything
if the same issue comes up later on, then we at least know the solution for now - and it really only affects pretty-printing things
you've also mentioned removing multerr in the future so this will handling will hopefully go away 🤞🏼
ilija42
previously approved these changes
May 23, 2024
|
ilija42
approved these changes
May 23, 2024
jmank88
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream: