cleanup: remove db config #709
Conversation
| } | ||
| return | ||
| return errors.Join(errA...) |
There was a problem hiding this comment.
Is this deferred join still necessary?
There was a problem hiding this comment.
It looks like the internal types will superficially be different, but if we are just using Unwrap() []error, then we still see the same slice: https://go.dev/play/p/65QFKJrpODU
There was a problem hiding this comment.
yeah we are really just using Unwrap() []error but I think everything is passed around via the error interface?
this seems like the simplest way to meet that interface without implementing a new type
There was a problem hiding this comment.
I mean that there should be no difference. Are you certain this is necessary?
There was a problem hiding this comment.
If you mean that we depend on always having something that implements Unwrap() []error, then couldn't we can relax that assumption and do a conversion for the base cases of 0/1 on the other side?
There was a problem hiding this comment.
update: this is the only way that works right now - doing a recursive unwrap within core does not solve the issue
There was a problem hiding this comment.
revisiting in a future ticket: https://smartcontract-it.atlassian.net/browse/BCI-3330
aalu1418
force-pushed
the
cleanup/remove-db-config
branch
from
d4bfeee to
76ce2a8
Compare
|
core ref: c00f33248fe41faafaf67315d3c2665ba0656488
downstream: