Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRF-817: run all VRF V2 tests in CI #11620

Merged
merged 2 commits into from
Dec 19, 2023
Merged

VRF-817: run all VRF V2 tests in CI #11620

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c91772
VRF-817: run all VRF V2 tests in CI
iljapavlovs Dec 19, 2023
709c61e
Merge branch 'develop' into chore/VRF-817-run-all-vrfv2-tests-in-ci
iljapavlovs Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,6 @@ jobs:
pyroscope_env: ci-smoke-vrf-evm-simulated
- name: vrfv2
nodes: 1
run: -run TestVRFv2MultipleSendingKeys
file: vrfv2
os: ubuntu-latest
pyroscope_env: ci-smoke-vrf2-evm-simulated
- name: vrfv2plus
Expand Down
7 changes: 5 additions & 2 deletions integration-tests/smoke/vrfv2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,13 +306,16 @@ func TestVRFv2MultipleSendingKeys(t *testing.T) {
t.Parallel()
l := logging.GetTestLogger(t)

network, err := actions.EthereumNetworkConfigFromEnvOrDefault(l)
require.NoError(t, err, "Error building ethereum network config")

var vrfv2Config vrfv2_config.VRFV2Config
err := envconfig.Process("VRFV2", &vrfv2Config)
err = envconfig.Process("VRFV2", &vrfv2Config)
require.NoError(t, err)

env, err := test_env.NewCLTestEnvBuilder().
WithTestInstance(t).
WithGeth().
WithPrivateEthereumNetwork(network).
WithCLNodes(1).
WithFunding(big.NewFloat(vrfv2Config.ChainlinkNodeFunding)).
WithStandardCleanup().
Expand Down
15 changes: 11 additions & 4 deletions integration-tests/smoke/vrfv2plus_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,13 +611,16 @@ func TestVRFv2PlusMultipleSendingKeys(t *testing.T) {
t.Parallel()
l := logging.GetTestLogger(t)

network, err := actions.EthereumNetworkConfigFromEnvOrDefault(l)
require.NoError(t, err, "Error building ethereum network config")

var vrfv2PlusConfig vrfv2plus_config.VRFV2PlusConfig
err := envconfig.Process("VRFV2PLUS", &vrfv2PlusConfig)
err = envconfig.Process("VRFV2PLUS", &vrfv2PlusConfig)
require.NoError(t, err)

env, err := test_env.NewCLTestEnvBuilder().
WithTestInstance(t).
WithGeth().
WithPrivateEthereumNetwork(network).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are using the PoS network for these tests after all? Or does this change imply something else?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ETH2_EL_CLIENT env var is not set, then it will use PoW with Geth by default

code

WithCLNodes(1).
WithFunding(big.NewFloat(vrfv2PlusConfig.ChainlinkNodeFunding)).
WithStandardCleanup().
Expand Down Expand Up @@ -702,13 +705,17 @@ func TestVRFv2PlusMultipleSendingKeys(t *testing.T) {
func TestVRFv2PlusMigration(t *testing.T) {
t.Parallel()
l := logging.GetTestLogger(t)

network, err := actions.EthereumNetworkConfigFromEnvOrDefault(l)
require.NoError(t, err, "Error building ethereum network config")

var vrfv2PlusConfig vrfv2plus_config.VRFV2PlusConfig
err := envconfig.Process("VRFV2PLUS", &vrfv2PlusConfig)
err = envconfig.Process("VRFV2PLUS", &vrfv2PlusConfig)
require.NoError(t, err)

env, err := test_env.NewCLTestEnvBuilder().
WithTestInstance(t).
WithGeth().
WithPrivateEthereumNetwork(network).
WithCLNodes(1).
WithFunding(big.NewFloat(vrfv2PlusConfig.ChainlinkNodeFunding)).
WithStandardCleanup().
Expand Down
Loading