VRF-817: run all VRF V2 tests in CI #11620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
ibrajer
reviewed
Dec 19, 2023
| require.NoError(t, err) | ||
|
|
||
| env, err := test_env.NewCLTestEnvBuilder(). | ||
| WithTestInstance(t). | ||
| WithGeth(). | ||
| WithPrivateEthereumNetwork(network). |
There was a problem hiding this comment.
So we are using the PoS network for these tests after all? Or does this change imply something else?
There was a problem hiding this comment.
if ETH2_EL_CLIENT env var is not set, then it will use PoW with Geth by default
|
SonarQube Quality Gate
|
ibrajer
approved these changes
Dec 19, 2023
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.