Deprecate onSubscribe() in favor or onSubscription() #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
requested changes
May 17, 2021
| @@ -22,9 +22,9 @@ | |||
| * | |||
| * <pre> | |||
There was a problem hiding this comment.
should we rename this class to UniOnSubscription?
There was a problem hiding this comment.
That'd break runtime compatibility.
| @@ -22,9 +22,9 @@ | |||
| * | |||
There was a problem hiding this comment.
should we rename this class to MultiOnSubscription?
There was a problem hiding this comment.
That'd break runtime compatibility.
implementation/src/main/java/io/smallrye/mutiny/operators/AbstractMulti.java
Outdated
Show resolved
Hide resolved
implementation/src/main/java/io/smallrye/mutiny/operators/AbstractUni.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
============================================
+ Coverage 89.67% 90.06% +0.39%
- Complexity 2915 2929 +14
============================================
Files 380 380
Lines 11513 11515 +2
Branches 1450 1452 +2
============================================
+ Hits 10324 10371 +47
+ Misses 610 588 -22
+ Partials 579 556 -23
|
Co-authored-by: Clement Escoffier <[email protected]>
Co-authored-by: Clement Escoffier <[email protected]>
cescoffier
approved these changes
May 17, 2021
cescoffier
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.