Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the onSubscribe group to onSubscription #562

Closed
cescoffier opened this issue May 17, 2021 · 5 comments · Fixed by #563
Closed

Rename the onSubscribe group to onSubscription #562

cescoffier opened this issue May 17, 2021 · 5 comments · Fixed by #563
Assignees
@jponge
Milestone
0.18.0

Comments

@cescoffier
Copy link
Contributor

It is invoked when the subscription event is received, and it's the only on group using a verb.
@cescoffier cescoffier added this to the 0.18.0 milestone May 17, 2021
@jponge
Copy link
Member

jponge commented May 17, 2021

Agreed

@jponge jponge self-assigned this May 17, 2021
@jponge
Copy link
Member

jponge commented May 17, 2021

Preparing a PR

@agoncal
Copy link

agoncal commented May 17, 2021

Sorry about being picky on wording ;o) https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/onSubscribe.28.29.20or.20onSubscription.28.29.20.3F

@jponge
Copy link
Member

jponge commented May 17, 2021

@agoncal that actually makes sense 😉

@jponge jponge linked a pull request May 17, 2021 that will close this issue
Deprecate onSubscribe() in favor or onSubscription() #563
Merged
@jponge
Copy link
Member

jponge commented May 17, 2021

See #563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jponge jponge

Labels
None yet
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

Deprecate onSubscribe() in favor or onSubscription() smallrye/smallrye-mutiny
3 participants
@jponge @cescoffier @agoncal