dont require enum to contain new engine names (DynamoDS#13841)

sm6srw · Mar 29, 2023 · 85ee523 · 85ee523
1 parent 956295a
commit 85ee523
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/Libraries/PythonNodeModels/PythonNode.cs b/src/Libraries/PythonNodeModels/PythonNode.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.ComponentModel;
@@ -54,6 +54,11 @@ public PythonEngineVersion Engine
                 if (!Enum.TryParse(engine, out PythonEngineVersion engineVersion) ||
                     engineVersion == PythonEngineVersion.Unspecified)
                 {
+                    //if this is a valid dynamically loaded engine, return unknown, and serialize the name.
+                    if (PythonEngineManager.Instance.AvailableEngines.Any(x=>x.Name == engine))
+                    {
+                        return PythonEngineVersion.Unknown;
+                    }
                     // This is a first-time case for newly created nodes only
                     SetEngineByDefault();
                 }
@@ -431,4 +436,4 @@ public override IEnumerable<AssociativeNode> BuildOutputAst(
             };
         }
     }
-}
+}
diff --git a/src/NodeServices/PythonServices.cs b/src/NodeServices/PythonServices.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
@@ -19,7 +19,8 @@ public enum PythonEngineVersion
     {
         Unspecified,
         IronPython2,
-        CPython3
+        CPython3,
+        Unknown
     }
 }