support serializing dynamic python engines #13841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
approved these changes
Mar 22, 2023
pinzart90
reviewed
Mar 22, 2023
| //if this is a valid dynamically loaded engine, return unknown, and serialize the name. | ||
| if (PythonEngineManager.Instance.AvailableEngines.Any(x=>x.Name == engine)) | ||
| { | ||
| return PythonEngineVersion.Unknown; |
There was a problem hiding this comment.
why isn't PythonEngineVersion.Unspecified good enough to be returned ?
There was a problem hiding this comment.
@pinzart90 - two reasons IMO:
- If the version is unspecified it makes sense to me that the default version should kick in.
- Logically
Unspecifiedis not the same asUnknown. In this case the version is definitely specified, it's just not a valid value in the enum.
There was a problem hiding this comment.
So all this is to enhance the user experience for an obsoleted API? Is it still used by our integrators ?
There was a problem hiding this comment.
hah, not quite, I don't know who uses it, and I don't know when it will disappear, and IMO it is about enhancing correctness not user experience - not collapsing two different states into one.
Let us remove this enum and never mention it again, but until then, I don't want to break python node initialization and I also want dynamic engines to serialize correctly.
pinzart90
approved these changes
Mar 23, 2023
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
while working on IronPython3 package recharge project I noticed that dynamic engine names were not serializing correctly because of an obsolete public API that requires returning an enum.. This PR works around that.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of