Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recentering viewport if the bounding box is max size 0 #3591

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Avoid recentering viewport if the bounding box is max size 0 #3591

merged 1 commit into from
Dec 16, 2016

Conversation

lordofhyphens
Copy link
Member

@lordofhyphens lordofhyphens commented Nov 27, 2016 •
edited
Loading

Defensive coding - fix provided by @jreinam

Fixes #3589

@lordofhyphens lordofhyphens added this to the 1.3.0 milestone Nov 27, 2016
@alranel
Copy link
Member

alranel commented Nov 27, 2016

Oh thank you, I had already implemented another fix in the mean time. zoom_to_bounding_box should be never called on an empty bounding box.

@alranel alranel closed this Nov 27, 2016
@lordofhyphens lordofhyphens deleted the 3589-viewport-divide-by-zero branch November 27, 2016 17:50
@lordofhyphens
Copy link
Member Author

Works for me, I'll close the related issue then.

@lordofhyphens lordofhyphens restored the 3589-viewport-divide-by-zero branch November 28, 2016 02:42
@lordofhyphens
Copy link
Member Author

Perhaps we should merge this in to cover the situation? We could be chasing down marginal cases for weeks.

@jreinam jreinam mentioned this pull request Dec 2, 2016
Closed
@lordofhyphens
Copy link
Member Author

Apparently it still is in a few cases.

@lordofhyphens lordofhyphens reopened this Dec 7, 2016
@lordofhyphens lordofhyphens mentioned this pull request Dec 7, 2016
Closed
@lordofhyphens lordofhyphens requested a review from alranel December 9, 2016 14:52
@lordofhyphens
Copy link
Member Author

I think this is necessary for defensive coding (avoid crashes). Alternative I think is to invent a flag to not trigger the draw/update until slicing is complete, but if your BB is zero/invalid it amounts to the same thing, doesn't it?

@lordofhyphens lordofhyphens mentioned this pull request Dec 14, 2016
Closed
@gege2b gege2b mentioned this pull request Dec 15, 2016
Closed
@alranel alranel merged commit 7472077 into slic3r:master Dec 16, 2016
@lordofhyphens lordofhyphens deleted the 3589-viewport-divide-by-zero branch November 6, 2018 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alranel alranel Awaiting requested review from alranel alranel is a code owner

Assignees

@alranel alranel

Labels
UI: Plater
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Division by zero when chaning to spiralize mode
2 participants
@lordofhyphens @alranel