Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from JSR-305 annotations to Checker ones #195

Closed
sleberknight opened this issue Feb 22, 2023 · 1 comment · Fixed by #199
Closed

Change from JSR-305 annotations to Checker ones #195

sleberknight opened this issue Feb 22, 2023 · 1 comment · Fixed by #199
Assignees
@sleberknight
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools dependencies Pull requests that update a dependency file
Milestone
0.1.0

Comments

@sleberknight
Copy link
Owner

sleberknight commented Feb 22, 2023 •
edited
Loading

There are a few JSR-305 annotations lurking about. These should be changed to Checker ones (also see #194). Some good reasons to do this are here and here.

We mostly use @Nullable and there is one usage of @NotThreadSafe. Checker has its own @Nullable. I am not sure about an equivalent for @NotThreadSafe.

Once annotations have been changed, we can remove the JSR-305 dependency.

We need to do this in all our other kiwiproject repositories too!!!
@sleberknight sleberknight added dependencies Pull requests that update a dependency file code cleanup Fix issues reported by Sonar or any other code analysis tools labels Feb 22, 2023
@sleberknight sleberknight self-assigned this Feb 22, 2023
@sleberknight sleberknight changed the title Change from JSR305 annotations to Checker ones Change from JSR-305 annotations to Checker ones Feb 22, 2023
@sleberknight sleberknight added this to the 0.1.0 milestone Mar 7, 2023
@sleberknight
Copy link
Owner Author

Since there does not seem to be an equivalent in Checker for @NotThreadSafe, just remove it for now. Maybe create our own?

sleberknight added a commit that referenced this issue Mar 7, 2023
@sleberknight
Replace JSR-305 annotations with Checker ones
1c4a82f 
Closes #195
@sleberknight sleberknight mentioned this issue Mar 7, 2023
Merged
dsingley pushed a commit that referenced this issue Mar 7, 2023
@sleberknight
Replace JSR-305 annotations with Checker ones (#199)
bf3156c 
Closes #195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Replace JSR-305 annotations with Checker ones sleberknight/kiwi-beta
1 participant
@sleberknight