Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need to add checker dependencies directly? #194

Closed
sleberknight opened this issue Feb 22, 2023 · 0 comments · Fixed by #198
Closed

Do we need to add checker dependencies directly? #194

sleberknight opened this issue Feb 22, 2023 · 0 comments · Fixed by #198
Assignees
@sleberknight
Labels
dependencies Pull requests that update a dependency file
Milestone
0.1.0

Comments

@sleberknight
Copy link
Owner

We are using Checker framework annotations such as @Nullable but we don't directly depend on checker, e.g. checker-qual. We probably should depend on it directly instead of transitively.
@sleberknight sleberknight added the dependencies Pull requests that update a dependency file label Feb 22, 2023
@sleberknight sleberknight self-assigned this Feb 22, 2023
@sleberknight sleberknight mentioned this issue Feb 22, 2023
Closed
sleberknight added a commit that referenced this issue Mar 7, 2023
@sleberknight
Add direct dependency on checker-qual
124a2cc 
Closes #194
@sleberknight sleberknight mentioned this issue Mar 7, 2023
Merged
chrisrohr pushed a commit that referenced this issue Mar 7, 2023
@sleberknight
Add direct dependency on checker-qual (#198)
b30ed12 
* Add direct dependency on checker-qual

Closes #194

* Add newline at end of file
@sleberknight sleberknight added this to the 0.1.0 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Add direct dependency on checker-qual sleberknight/kiwi-beta
1 participant
@sleberknight