Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old image files #246

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

nneveu
Copy link
Member

@nneveu nneveu commented Feb 25, 2025

Summary of changes

Removing image.py and fitting_tool.py. These files should have been deleted when the image and fit folders were refactored.

Additional notes

I'm still not happy with some of the file names/structure related to image/fit. That will have to wait for another PR.

This merge will close #225

@nneveu nneveu requested review from pluflou and eloiseyang February 25, 2025 18:14
@nneveu
Copy link
Member Author

nneveu commented Feb 25, 2025

Of course I forgot to clean up the other files...working on it.

@pluflou
Copy link
Collaborator

pluflou commented Feb 25, 2025

@nneveu you need to make the PR from a branch on the main repo for the meme package to be installed otherwise the tests will fail when creating a PR to main (I'm starting to think that maybe this way of doing things isn't the most efficient way of doing things)

@nneveu
Copy link
Member Author

nneveu commented Feb 25, 2025

I see, can we switch to Paul's suggestion then? And just import meme in the one place it's asked for?

@eloiseyang
Copy link
Collaborator

I think moving to Paul's suggestion in this case is fine. That being said, I think it's likely we will have to import a module from a private repo again. We can work out another solution when that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use root_mean_squared_error, because mean_squared_error(squared=False) is deprecated
3 participants