Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Keep scroll view content inset adjustment #643

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Keep scroll view content inset adjustment #643

merged 1 commit into from
Nov 1, 2017

Conversation

gim-
Copy link
Contributor

@gim- gim- commented Oct 29, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

This fixes the issue for non-inverted table views when navigation bar was overlaying it. It was caused by _tableView.contentInsetAdjustmentBehavior being set to UIScrollViewContentInsetAdjustmentNever. I added a new method slk_updateInsetAdjustmentBehavior which updates adjustment behavior when isInverted field is mutated and sets an appropriate adjustment type based on the new value.

Related Issues

Fixes #642
Related to change from #631

@gim- gim- changed the title Keep scroll view content inset adjustment. Fixes #642 Keep scroll view content inset adjustment Oct 29, 2017
@dzenbot dzenbot added the iOS 11 label Nov 1, 2017
@dzenbot
Copy link

dzenbot commented Nov 1, 2017

Great fix @gim- !
I tested on simulator and device, and against the iPhoneX branch and it works like a charm! Thank you.

@dzenbot dzenbot merged commit ad1675e into slackhq:master Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UINavigationBar overlays top table view cell when isInverted is set to false
2 participants