Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

UINavigationBar overlays top table view cell when isInverted is set to false #642

Closed
4 tasks done
gim- opened this issue Oct 29, 2017 · 1 comment · Fixed by #643
Closed
4 tasks done

UINavigationBar overlays top table view cell when isInverted is set to false #642

gim- opened this issue Oct 29, 2017 · 1 comment · Fixed by #643

Comments

@gim-
Copy link
Contributor

gim- commented Oct 29, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Description

Navigation bar hides the very top cell when isInverted flag is set to false.

Reproducible in:

  • This is reproducible in the sample project.
    SlackTextViewController version: master branch (commit: d5e01fc)
    iOS version(s): iOS 11
    Device(s): any

Steps to reproduce:

  1. Open Swift Example project
  2. Change self.isInverted = true to self.isInverted = false
  3. Launch the project and scroll to top

Expected result:

Top table view cell should be below navigation bar

Actual result:

Top table view cell is behind navigation bar

Attachments:

https://www.dropbox.com/s/z3z9y3qyvtxrfaj/slacklib.mov?dl=0

@gim-
Copy link
Contributor Author

gim- commented Oct 29, 2017

This issue is not present in 4c74cba so I assume it has something to do with this change: d5e01fc

I used commit lock in my Podfile as a workaround for now:

pod 'SlackTextViewController', :git => 'https://github.com/slackhq/SlackTextViewController', :commit => '4c74cbab29408dda9af33633f86dcc983a3b5363'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant