-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #689 by adding flags in AppConfig #690
Fix #689 by adding flags in AppConfig #690
Conversation
Codecov Report
@@ Coverage Diff @@
## main #690 +/- ##
============================================
+ Coverage 77.80% 77.83% +0.03%
- Complexity 3216 3222 +6
============================================
Files 359 359
Lines 9464 9467 +3
Branches 892 895 +3
============================================
+ Hits 7363 7369 +6
+ Misses 1561 1560 -1
+ Partials 540 538 -2
Continue to review full report at Codecov.
|
@seratch Thank you for picking this up so quickly! ❤️ The PR looks good to me! My only suggestion would be to update the middleware documentation to add a note about the ability to disable default middleware, which would be a good place to add a warning about the fact that disabling request verification is not recommended for security reasons, as you mentioned in the description. |
5e817f2
to
9aedef2
Compare
@luispollo Thanks for the suggestion! I've updated the documents in this pull request ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition. Is it something we want to bring to JavaScript and Python?
Co-authored-by: Michael Brooks <[email protected]>
It may be worth considering to add these options to Python as its |
Thanks for the suggestions on the document 🙇 |
Hi @seratch, thank you for fixing the issue for us! When it will be available for use at the SDK level? |
@gal-yardeni We'll release a new version within a few hours! |
that's awesome! thanks for the update! |
This pull request fixes #689 by adding flags in
AppConfig
. Refer to the issue for the context.We do not usually recommend turning the built-in middleware off. Especially, disabling request verification just for easiness is not great from security perspective. These flags are available only for the use case like #689 or debugging purposes.
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.