Fixes and polish for stable release #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-functions #2128 +/- ##
==================================================
+ Coverage 81.43% 81.58% +0.15%
==================================================
Files 19 19
Lines 1621 1640 +19
Branches 458 462 +4
==================================================
+ Hits 1320 1338 +18
Misses 194 194
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
2 tasks
misscoded
force-pushed
the
pre-stable-fixes
branch
from
ab80d52 to
9df1e68
Compare
misscoded
force-pushed
the
pre-stable-fixes
branch
from
9df1e68 to
f7966e7
Compare
zimeg
approved these changes
Aug 7, 2024
| @@ -13,7 +13,7 @@ import { | |||
| FunctionExecutedEvent, | |||
| } from './types'; | |||
| import processMiddleware from './middleware/process'; | |||
| import { CustomFunctionInitializationError } from './errors'; | |||
| import { CustomFunctionCompleteFailError, CustomFunctionCompleteSuccessError, CustomFunctionInitializationError } from './errors'; | |||
There was a problem hiding this comment.
We might want to just use the CustomFunctionInitializationError error here to not confuse initialization and runtime errors 🤔
| @@ -1088,6 +1093,7 @@ export default class App<AppCustomContext extends StringIndexed = StringIndexed> | |||
| if (type === IncomingEventType.Action && context.functionExecutionId !== undefined) { | |||
| listenerArgs.complete = CustomFunction.createFunctionComplete(context, client); | |||
| listenerArgs.fail = CustomFunction.createFunctionFail(context, client); | |||
| listenerArgs.inputs = context.functionInputs; | |||
There was a problem hiding this comment.
Just sharing as an option, free to ignore- all listener arguments could be created and assigned with Object.assign if we wanted to reduce the number of CustomFunction exports
| @@ -1,7 +1,7 @@ | |||
| import { WebClient } from '@slack/web-api'; | |||
| import { Logger } from '@slack/logger'; | |||
| import { StringIndexed } from './helpers'; | |||
| import { SlackEventMiddlewareArgs } from './events'; | |||
| import { FunctionInputs, SlackEventMiddlewareArgs } from './events'; | |||
There was a problem hiding this comment.
Could these be imported from ./functions instead?
filmaj
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Final preparations and polish prior to cutting a stable release. 💅🏼
inputsavailable by way ofContextfor interactivity events that are associated with a function's executionContextinterfacefunctionExecutionIdsomehow goes missing when using a utilityfeat-functions) PR feedback (TS fixes)actionpayloadRequirements (place an
xin each[ ])