Remote Functions: Change how webclient options are constructed in CustomFunction #2190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of spreading the existing app-level webclient properties as options when constructing the web client, expose a getter on
App
to retrieve the user-provided original assembled web client options and construct aCustomFunction
instance that way.This ensures no funny business using the spread operator (like spreading readonly properties) and ensures the original user-provided web client options are honoured.
Also adds a couple of tests for
CustomFunction
complete/fail factory methods to increase test coverage a tad.Should address the two remaining "in progress" List items assigned to me for Remote Functions GA.