Fix #1488 Incorrect types with ViewUpdateResponseAction and ViewPushResponseAction #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewPushResponseAction
seratch
added
bug
seratch
commented
Jun 17, 2022
| @@ -62,7 +62,7 @@ export interface ViewSubmitAction { | |||
| id: string; | |||
| name: string; | |||
| }; | |||
| response_urls: ViewResponseUrl[]; | |||
| response_urls?: ViewResponseUrl[]; | |||
There was a problem hiding this comment.
while reviewing the changes again, I found that this field needs to be optional
| @@ -103,7 +103,7 @@ export interface ViewClosedAction { | |||
|
|
|||
| export interface ViewWorkflowStepSubmitAction extends ViewSubmitAction { | |||
| trigger_id: string; | |||
| response_urls: ViewResponseUrl[]; | |||
| response_urls?: ViewResponseUrl[]; | |||
| @@ -174,12 +174,12 @@ export interface ViewOutput { | |||
|
|
|||
| export interface ViewUpdateResponseAction { | |||
| response_action: 'update'; | |||
| view: ViewOutput; | |||
| view: View; | |||
There was a problem hiding this comment.
these reverting changes are for #1488
Codecov Report
@@ Coverage Diff @@
## main #1490 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 18 18
Lines 1494 1494
Branches 435 435
=======================================
Hits 1225 1225
Misses 172 172
Partials 97 97 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #1488
Requirements (place an
xin each[ ])