Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect types with ViewUpdateResponseAction and ViewPushResponseAction #1488

Closed
4 of 10 tasks
ducminh-phan opened this issue Jun 16, 2022 · 1 comment · Fixed by #1490
Closed
4 of 10 tasks

Incorrect types with ViewUpdateResponseAction and ViewPushResponseAction #1488

ducminh-phan opened this issue Jun 16, 2022 · 1 comment · Fixed by #1490
Assignees
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Milestone

Comments

@ducminh-phan
Copy link

Description

After upgrading from 3.11.1 to 3.11.2, ViewUpdateResponseAction and ViewPushResponseAction include more required fields that should not be there. This originates from #1455.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Reproducible in

package version: 3.11.2

node version: any version

OS version(s): any OS

Steps to reproduce

  1. Install @slack/bolt 3.11.1
  2. Write a view submission handler with an ack to push/update views, the below snippet provides an MWE
app.view("callback_id", async ({ ack }) => {
  await ack({
    response_action: "push",
    view: {
      type: "modal",
      title: {
        type: "plain_text",
        text: "Title",
      },
      blocks: [],
    },
  });
});
  1. Upgrade @slack/bolt to 3.11.2

Expected result

Typescript accepts the above snippet. Slack API reference

Actual result

Typescript rejects the above snippet

Attachments

Screen Shot 2022-06-16 at 09 17 24

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Jun 16, 2022
@seratch seratch added this to the 3.11.3 milestone Jun 16, 2022
@seratch seratch self-assigned this Jun 16, 2022
@seratch
Copy link
Member

seratch commented Jun 16, 2022

Hi @ducminh-phan, thanks for reporting this issue and we are sorry about the disruption. We will quickly resolve this issue and ship a new patch version as early as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants