Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make events in the document clearer #1046

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

RhnSharma
Copy link
Contributor

Summary

Fixes #1013
Hi @seratch, I have made the same changes as slackapi/bolt-python#415 to this project.
How does this look? Let me know if this needs any changes.
Thanks

Requirements (place an x in each [ ])

@seratch
Copy link
Member

seratch commented Aug 10, 2021

To: assigned reviewers,
The changes look almost the same with the ones fo bolt-python at a glance but, can you check them?

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left one small comment on two missed relevant changes in one of the files. Thanks for tackling this!

docs/_advanced/middleware_global.md Show resolved Hide resolved
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround! Looks awesome, appreciate your efforts here 🙏

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #1046 (0a6e652) into main (a2324c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          13       13           
  Lines        1212     1212           
  Branches      357      357           
=======================================
  Hits          835      835           
  Misses        304      304           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2324c6...0a6e652. Read the comment docs.

@seratch seratch added docs M-T: Documentation work only and removed untriaged labels Aug 11, 2021
@seratch seratch added this to the 3.6.0 milestone Aug 11, 2021
@seratch seratch merged commit 62f60a2 into slackapi:main Aug 11, 2021
seratch added a commit to seratch/bolt-js that referenced this pull request Oct 7, 2021
@seratch seratch mentioned this pull request Oct 7, 2021
2 tasks
seratch added a commit that referenced this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "events" in the document even clearer
3 participants