-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: make events in the document clearer #1046
Conversation
To: assigned reviewers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left one small comment on two missed relevant changes in one of the files. Thanks for tackling this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround! Looks awesome, appreciate your efforts here 🙏
Codecov Report
@@ Coverage Diff @@
## main #1046 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 13 13
Lines 1212 1212
Branches 357 357
=======================================
Hits 835 835
Misses 304 304
Partials 73 73 Continue to review full report at Codecov.
|
Summary
Fixes #1013
Hi @seratch, I have made the same changes as slackapi/bolt-python#415 to this project.
How does this look? Let me know if this needs any changes.
Thanks
Requirements (place an
x
in each[ ]
)