Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese: Make "events" in the document even clearer (#1013) #1047

Closed
4 of 10 tasks
seratch opened this issue Aug 7, 2021 · 1 comment · Fixed by #1152
Closed
4 of 10 tasks

Japanese: Make "events" in the document even clearer (#1013) #1047

seratch opened this issue Aug 7, 2021 · 1 comment · Fixed by #1152
Assignees
@wongjas
Labels
docs M-T: Documentation work only good first issue Good for newcomers
Milestone
3.8.0

Comments

@seratch
Copy link
Member

seratch commented Aug 7, 2021 •
edited by wongjas
Loading

Description

We can apply the #1013 #1046 changes to Japanese document pages.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added docs M-T: Documentation work only good first issue Good for newcomers labels Aug 7, 2021
@seratch seratch added this to the 3.x milestone Aug 7, 2021
@seratch
Copy link
Member Author

seratch commented Oct 7, 2021

Also #1147 changes should be considered in this task

@wongjas wongjas self-assigned this Oct 11, 2021
@seratch seratch mentioned this issue Oct 11, 2021
Merged
2 tasks
@seratch seratch modified the milestones: 3.x, 3.8.0 Oct 11, 2021
seratch pushed a commit that referenced this issue Oct 12, 2021
@wongjas
Fix #1047 Japanese: Make "events" in the document even clearer (#1152)
7f1ec57 
* change instances of events to requests in reference to slack requests
* change "request source" back to "event source" and update middleware error as per suggestions
srajiang pushed a commit to srajiang/bolt-js that referenced this issue Oct 14, 2021
@wongjas @srajiang
Fix slackapi#1047 Japanese: Make "events" in the document even clearer (
e9e9353 
slackapi#1152)

* change instances of events to requests in reference to slack requests
* change "request source" back to "event source" and update middleware error as per suggestions
srajiang pushed a commit to srajiang/bolt-js that referenced this issue Oct 20, 2021
@wongjas @srajiang
Fix slackapi#1047 Japanese: Make "events" in the document even clearer (
32ab806 
slackapi#1152)

* change instances of events to requests in reference to slack requests
* change "request source" back to "event source" and update middleware error as per suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wongjas wongjas

Labels
docs M-T: Documentation work only good first issue Good for newcomers
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Fix #1047 Japanese: Make "events" in the document even clearer slackapi/bolt-js
2 participants
@seratch @wongjas