Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a signature validation function that is not tied to the request #1385

Closed
4 of 10 tasks
danerwilliams opened this issue Mar 23, 2022 · 1 comment · Fixed by #1392
Closed
4 of 10 tasks

Create a signature validation function that is not tied to the request #1385

danerwilliams opened this issue Mar 23, 2022 · 1 comment · Fixed by #1392
Assignees
Labels
enhancement M-T: A feature request for new functionality
Milestone

Comments

@danerwilliams
Copy link

danerwilliams commented Mar 23, 2022

Description

There is currently a PR #1359 and issue #1358 to expose common utilities, including a signature validation function .

This issue suggests creation of a signature validation function that is less tightly coupled to the request than the function that will be exposed in #1359.

With the existing function, it becomes difficult to use with nest.js or other frameworks that modify incoming requests. Ideally this function would take the request body + headers, and signing secret. It would then perform the validation and if successful return the webhook's event object.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch self-assigned this Mar 23, 2022
@seratch seratch added the enhancement M-T: A feature request for new functionality label Mar 23, 2022
@seratch seratch added this to the 3.11.0 milestone Mar 23, 2022
@seratch
Copy link
Member

seratch commented Mar 23, 2022

Hi @danerwilliams, thanks for the great suggestion! We will consider having an additional utility for your use case in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants