Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose common utilities for building HTTP module based receivers #1358

Closed
4 of 10 tasks
seratch opened this issue Mar 7, 2022 · 0 comments · Fixed by #1359
Closed
4 of 10 tasks

Expose common utilities for building HTTP module based receivers #1358

seratch opened this issue Mar 7, 2022 · 0 comments · Fixed by #1359
Assignees
@seratch
Labels
discussion M-T: An issue where more input is needed to reach a decision enhancement M-T: A feature request for new functionality
Milestone
3.11.0

Comments

@seratch
Copy link
Member

seratch commented Mar 7, 2022

Description

Currently, implementing your own receivers would take some time and, not only that, its maintenance cost is not so small. To get rid of this burden from community developers and us, we can extract common methods and interface from the built-in HTTPReceiver and ExpressReceiver and then, expose those in src/indext.ts, to enable extrenal code to take advantage of those code in the future.

I will come up with a draft pull request that illustrate my initial idea for it. Let's discuss the details in the reviews!

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added enhancement M-T: A feature request for new functionality discussion M-T: An issue where more input is needed to reach a decision labels Mar 7, 2022
@seratch seratch added this to the 3.11.0 milestone Mar 7, 2022
@seratch seratch self-assigned this Mar 7, 2022
seratch added a commit to seratch/bolt-js that referenced this issue Mar 7, 2022
@seratch
Fix slackapi#1358 Expose common utilities for building HTTP module ba…
4e052f2 
…sed receivers
@seratch seratch mentioned this issue Mar 7, 2022
Merged
2 tasks
@danerwilliams danerwilliams mentioned this issue Mar 23, 2022
Closed
10 tasks
seratch added a commit to seratch/bolt-js that referenced this issue Mar 25, 2022
@seratch
Fix slackapi#1358 Expose common utilities for building HTTP module ba…
60eb6fe 
…sed receivers
seratch added a commit to seratch/bolt-js that referenced this issue Mar 26, 2022
@seratch
Fix slackapi#1358 Expose common utilities for building HTTP module ba…
6930377 
…sed receivers
seratch added a commit that referenced this issue Mar 26, 2022
@seratch @filmaj
Fix #1358 Expose common utilities for building HTTP module based rece…
be526eb 
…ivers (#1359)

Co-authored-by: Fil Maj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
discussion M-T: An issue where more input is needed to reach a decision enhancement M-T: A feature request for new functionality
Projects
None yet
Milestone
3.11.0
Development

Successfully merging a pull request may close this issue.

Fix #1358 Expose common utilities for building HTTP module based receivers seratch/bolt-js
1 participant
@seratch