Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jobs] Refactor dashboard controller launching with systemd #4538

Merged
merged 5 commits into from
Jan 9, 2025
Merged

[Jobs] Refactor dashboard controller launching with systemd #4538

merged 5 commits into from
Jan 9, 2025

Conversation

KeplerC
Copy link
Collaborator

@KeplerC KeplerC commented Jan 7, 2025 •
edited
Loading

closes #4299 by systemd

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR
sky start sky-jobs-controller-<hash>
sky jobs launch --fast echo hi
curl localhost:5000

KeplerC added 2 commits January 6, 2025 12:56
@KeplerC
convert to systemd
7c4d925
@KeplerC
Refactor jobs-controller.yaml.j2 to use systemd user service for skyp…
81623a7 
…ilot-dashboard. Added user-specific environment variables and log redirection. Updated service management commands to operate in user mode.
@KeplerC KeplerC marked this pull request as ready for review January 7, 2025 02:01
@KeplerC KeplerC changed the title Fix dashboard [Jobs] Refactor dashboard controller launching with systemd Jan 7, 2025
@Michaelvll Michaelvll requested a review from cg505 January 7, 2025 05:21
@KeplerC
Enhance jobs-controller.yaml.j2 to check for systemd user service ava…
7a73aba 
…ilability before executing service management commands. If systemd is not found, implement a manual setup for the SkyPilot dashboard, including process termination and background launch. This improves robustness and user experience during setup.
cg505
cg505 previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@cg505 cg505 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, @KeplerC! I like the approach. Left a few comments to address.
Accidentally hit approve but I'll re-review after the changes.

sky/templates/jobs-controller.yaml.j2 Outdated Show resolved Hide resolved
sky/templates/jobs-controller.yaml.j2 Outdated Show resolved Hide resolved
sky/templates/jobs-controller.yaml.j2 Outdated Show resolved Hide resolved
sky/templates/jobs-controller.yaml.j2 Outdated Show resolved Hide resolved
@cg505 cg505 dismissed their stale review January 8, 2025 03:28

meant to comment, not approve

KeplerC and others added 2 commits January 8, 2025 11:19
@KeplerC @cg505
streamline sky/templates/jobs-controller.yaml.j2
4b2cf73 
Co-authored-by: Christopher Cooper <[email protected]>
@KeplerC
Refactor jobs-controller.yaml.j2 to remove Flask installation check a…
639538d 
…nd update systemd service configuration. Added Flask as a dependency in controller_utils.py for the dashboard. Changed service target from multi-user to default for improved service management.
@KeplerC KeplerC requested a review from cg505 January 9, 2025 17:55
cg505
cg505 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@KeplerC KeplerC merged commit bc777e2 into skypilot-org:master Jan 9, 2025
18 checks passed
@KeplerC KeplerC deleted the fix-dashboard branch January 9, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cg505 cg505 cg505 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Jobs] Jobs launch does not start the dashboard after starting the controller manually
2 participants
@KeplerC @cg505