Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jobs] Jobs launch does not start the dashboard after starting the controller manually #4299

Closed
Michaelvll opened this issue Nov 8, 2024 · 1 comment · Fixed by #4538
Closed
Assignees

Comments

@Michaelvll
Copy link
Collaborator

Reproduction:

  1. Start a stopped controller: sky start sky-jobs-controller-<hash>
  2. sky jobs launch --fast echo hi, this does not start the dashboard
    # Dashboard.
    ps aux | grep -v nohup | grep -v grep | grep -- "-m sky.spot.dashboard" | awk '{print $2}' | xargs kill > /dev/null 2>&1 || true
    pip list | grep flask > /dev/null 2>&1 || pip install flask 2>&1 > /dev/null
    ((ps aux | grep -v nohup | grep -v grep | grep -q -- "-m sky.jobs.dashboard.dashboard") || (nohup {{ sky_python_cmd }} -m sky.jobs.dashboard.dashboard >> ~/.sky/job-dashboard.log 2>&1 &));

Version & Commit info:

  • sky -v: PLEASE_FILL_IN
  • sky -c: PLEASE_FILL_IN
@cg505
Copy link
Collaborator

cg505 commented Nov 12, 2024

Think we should probably just try to avoid having this in setup commands. I wonder how difficult it would be to just add it as a systemd service or something like this so that it's always running.

@Michaelvll Michaelvll added the OSS label Dec 19, 2024 — with Linear
@Michaelvll Michaelvll removed the OSS label Dec 19, 2024
@Michaelvll Michaelvll added the OSS label Dec 19, 2024 — with Linear
@Michaelvll Michaelvll removed the OSS label Dec 19, 2024
@Michaelvll Michaelvll changed the title [Jobs] Jobs launch --fast does not start the dashboard [Jobs] Jobs launch does not start the dashboard after starting the controller manually Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants