Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Bug fix for Tag Values representing booleans being loaded as boolean instead of strings #3482

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[Core] Bug fix for Tag Values representing booleans being loaded as boolean instead of strings #3482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sky/templates/aws-ray.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ available_node_types:
Value: {{ user }}
{%- for tag_key, tag_value in instance_tags.items() %}
- Key: {{ tag_key }}
Value: {{ tag_value }}
Value: {{ tag_value|tojson }}
{%- endfor %}

head_node_type: ray.head.default
Expand Down Expand Up @@ -161,5 +161,3 @@ setup_commands:

# Command to start ray clusters are now placed in `sky.provision.instance_setup`.
# We do not need to list it here anymore.


2 changes: 1 addition & 1 deletion sky/templates/gcp-ray.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ available_node_types:
labels:
skypilot-user: {{ user }}
{%- for tag_key, tag_value in instance_tags.items() %}
{{ tag_key }}: {{ tag_value }}
{{ tag_key }}: {{ tag_value|tojson }}
{%- endfor %}
{%- if specific_reservations %}
reservationAffinity:
Expand Down
Loading