[Core] Bug fix for Tag Values representing booleans being loaded as boolean instead of strings #3482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates jinja2 ray templates for gcp and aws when utilizing Tags.
Currently, boolean strings are inserted into the Ray YAML without being escaped. This fixes that by using the builtin
tojson
function for jinja2.Otherwise, tags which had the values:
false
ortrue
would fail to launch.Tested (run the relevant ones):
bash format.sh
false
andtrue
set in the~/.sky/config.yaml
aws.instance_tags
sectionpytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh