[Docker image] Nightly build of docker image #2229

PratikKumar125 · 2023-07-13T14:34:38Z

Added two workflow files.

release-build.yaml, to build and push docker-images whenever any changes are made to existing release/* branch or any new release/* branch is created.
nightly-build.yaml, to build the master branch in every 24 Hours with the latest tag and push them to dockerhub.

NOTE:-You need to store dockerhub username and password as github secrets with the same keys as follows :-

DOCKER_USERNAME
DOCKER_PASSWORD

… into ci-cd/2193

romilbhardwaj

This is awesome, thanks @PratikKumar125! Trying it out now. Left some comments.

romilbhardwaj · 2023-07-13T17:12:45Z

.github/workflows/nightly-build.yaml

+        run: |
+          docker build -t $DOCKER_USERNAME/skypilot:latest .
+          docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
+          docker push $DOCKER_USERNAME/skypilot:latest


nit: new line at the end?

Same for other file

romilbhardwaj · 2023-07-13T17:14:00Z

.github/workflows/nightly-build.yaml

@@ -0,0 +1,24 @@
+name: Nightly Build


Can we call this docker-nightly-build so we don't confuse this with pypi/other builds?

romilbhardwaj · 2023-07-13T17:14:19Z

.github/workflows/release-build.yaml

@@ -0,0 +1,40 @@
+name: Release Build


Can we call this docker-release-build?

romilbhardwaj · 2023-07-13T17:23:58Z

.github/workflows/release-build.yaml

+on:
+  push:
+    branches:
+      - 'releases/*'


Let's use 'releases/**' to also catch any nested branches

romilbhardwaj · 2023-07-13T19:26:36Z

.github/workflows/nightly-build.yaml

@@ -0,0 +1,24 @@
+name: Nightly Build
+
+on:


Can we also add workflow_dispatch to allow manual override when required?

romilbhardwaj · 2023-07-13T19:28:05Z

.github/workflows/nightly-build.yaml

+  build:
+    runs-on: ubuntu-latest
+
+    steps:


Can we add a check to run the nightly build only if there have been changes in the last 24 hours? You may want to refer to this.

romilbhardwaj · 2023-07-13T19:29:42Z

.github/workflows/nightly-build.yaml

+        env:
+          DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
+          DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
+        run: |


Before building the nightly, can we also update the version str like we're planning to do in #1446? See reference code here:

skypilot/.github/workflows/pypi-nightly-build.yml

Lines 40 to 45 in ee1e576

- name: Set release version

run: |

RELEASE_VERSION=$(date +%Y%m%d)

sed -i "s/{{SKYPILOT_COMMIT_SHA}}/${{ github.sha }}/g" sky/__init__.py

sed -i "s/__version__ = '.*'/__version__ = '1.0.0-dev${RELEASE_VERSION}'/g" sky/__init__.py

sed -i "s/name='skypilot',/name='skypilot-nightly',/g" sky/setup_files/setup.py

Michaelvll · 2023-07-14T03:49:22Z

For discussion: How about having the docker release workflow in the same workflow file as the pypi release so as to make sure the commit hash are the same for both nightly release? https://github.com/skypilot-org/skypilot/blob/master/.github/workflows/pypi-nightly-build.yml

romilbhardwaj · 2023-07-14T17:00:29Z

For discussion: How about having the docker release workflow in the same workflow file as the pypi release so as to make sure the commit hash are the same for both nightly release? https://github.com/skypilot-org/skypilot/blob/master/.github/workflows/pypi-nightly-build.yml

+1 for having the same version. However, it might be better to have them as two different workflows for isolation (in case something breaks in either of the flows).. How about we pick the head commit at 12AM PT for both workflows to ensure version is same?

romilbhardwaj · 2023-07-14T23:55:04Z

Another thing to think about and probably can be deferred to a future PR - can we have different images for different dependencies? E.g., skypilot-aws:latest, skypilot-gcp:latest and so on? skypilot:latest can still have all dependencies installed.

This would help reduce bloat and pull times for users who use only a single cloud.

PratikKumar125 · 2023-07-15T09:46:59Z

Made some suggested changes. Require review.

…ch 'master' of github.com:skypilot-org/skypilot into ci-cd/2193

Michaelvll · 2024-01-22T23:05:46Z

Changed this to use the latest nightly build on pypi as a single source of truth. Tested in a fork and it works: https://github.com/michaelvll/skypilot/actions/workflows/docker-nightly-build.yaml

romilbhardwaj

Thanks @Michaelvll!

romilbhardwaj · 2024-01-25T04:33:14Z

.github/workflows/docker-nightly-build.yaml

+              apt install rsync vim -y && \
+              rm -rf /var/lib/apt/lists/*
+
+          RUN pip install "skypilot-nightly[aws,gcp,azure,kubernetes]==$LATEST_VERSION" --no-cache-dir


Might be worth a quick check to measure the size difference between an image with skypilot-nightly[aws,gcp,azure,kubernetes] vs skypilot-nightly[all]. If not too big, perhaps we can ship with skypilot-nightly[all]?

Good call! I was using the older python version and the installation of [all] seems taking forever, due to some dependency issue with the kubernetes extra for python 3.9. I just switched the base image to use python 3.10, and it seems working nicely with [all]

romilbhardwaj · 2024-01-25T04:44:15Z

.github/workflows/docker-nightly-build.yaml

+          push: true
+          tags: "${{ secrets.DOCKER_USERNAME }}/skypilot-nightly:latest,${{ secrets.DOCKER_USERNAME }}/skypilot-nightly:$LATEST_VERSION"
+          cache-from: type=gha
+          cache-to: type=gha,mode=max


Nit: since running a linux/amd64 image on apple silicon can be a bit slow because of emulation (e.g., on my M2 Mac, sky -v takes 4 seconds on this image compared to 1 second running natively), consider adding builds for apple silicon.

IIUC from this guide, it should involve:

Adding the qemu action above

- name: Set up QEMU uses: docker/setup-qemu-action@v3

In docker/build-push-action@v5, add:

platforms: linux/amd64,linux/arm64

Feel free to defer for a future PR.

Good call! I just tried adding it, but it seems the conda install -c conda-forge google-cloud-sdk fail to be installed in the linux/arm64 version. Do you have an idea how to resolve it?

…pilot into ci-cd/2193

PratikKumar125 added 9 commits July 13, 2023 10:08

added release build actions

069727d

added release build

6b4ac54

release build modified

06cf17f

Update release-build.yaml

394794f

Update release-build.yaml

a2cf2ef

Update release-build.yaml

2630f3a

Implemented release-build workflow.

47d1bc4

Added final nightly and release build workflows

4e7b7b3

Merge branch 'ci-cd/2193' of https://github.com/PratikKumar125/skypilot…

8863014

… into ci-cd/2193

romilbhardwaj self-requested a review July 13, 2023 15:23

romilbhardwaj reviewed Jul 13, 2023

View reviewed changes

made suggested changes in release and nightly workflow files

6eca4ed

Michaelvll mentioned this pull request Jul 15, 2023

[k8s] Kubernetes support #2096

Merged

2 tasks

Michaelvll requested a review from romilbhardwaj August 1, 2023 18:47

Michaelvll changed the title ~~CI-CD-#2193~~ [Docker image] Nightly build of docker image Oct 3, 2023

Michaelvll force-pushed the master branch from 71213e5 to 9743aa0 Compare January 13, 2024 05:30

Michaelvll added 10 commits January 22, 2024 21:35

Merge branch 'ci-cd/2193' of github.com:PratikKumar125/skypilot; bran…

c17cc0c

…ch 'master' of github.com:skypilot-org/skypilot into ci-cd/2193

Install nightly from pypi for docker build

5a5dfa4

fix username

4d82507

rename secrets

40ca1cf

test on push

f5031cb

fix password secret

f29a506

change to env

1e390a3

test

8840e34

avoid push on

f0132a2

Fix docker repo

fa8d932

Michaelvll added 9 commits January 22, 2024 22:48

test

02fd870

remove push

53f96d4

fix version

3a61ecd

test

107a5b9

remove push

6b96003

fix version

d7b9896

test

0ede04d

Change back to user name

adab2ea

remove push

e6af47c

remove python

f1f8000

romilbhardwaj approved these changes Jan 25, 2024

View reviewed changes

Michaelvll added 5 commits January 25, 2024 22:23

add arm64

fb9db50

Use python 3.10, update dockerfile to use

1b4900e

Merge branch 'test-docker-nightly-build' of github.com:Michaelvll/sky…

58ddc3a

…pilot into ci-cd/2193

Remove arm64

b8ab197

Change to python 3.10 for conda

39bf5b4

Michaelvll force-pushed the ci-cd/2193 branch from 753f9fa to 39bf5b4 Compare January 28, 2024 06:29

Michaelvll merged commit 9c08b7b into skypilot-org:master Jan 28, 2024
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Docker image] Nightly build of docker image #2229

[Docker image] Nightly build of docker image #2229

PratikKumar125 commented Jul 13, 2023 •

edited

Loading

romilbhardwaj left a comment

romilbhardwaj Jul 13, 2023

romilbhardwaj Jul 13, 2023

romilbhardwaj Jul 13, 2023

romilbhardwaj Jul 13, 2023

romilbhardwaj Jul 13, 2023

romilbhardwaj Jul 13, 2023

romilbhardwaj Jul 13, 2023

romilbhardwaj Jul 13, 2023

Michaelvll commented Jul 14, 2023 •

edited

Loading

romilbhardwaj commented Jul 14, 2023

romilbhardwaj commented Jul 14, 2023

PratikKumar125 commented Jul 15, 2023

Michaelvll commented Jan 22, 2024

romilbhardwaj left a comment

romilbhardwaj Jan 25, 2024

Michaelvll Jan 25, 2024

romilbhardwaj Jan 25, 2024

Michaelvll Jan 25, 2024

	- name: Set release version
	run: \|
	RELEASE_VERSION=$(date +%Y%m%d)
	sed -i "s/{{SKYPILOT_COMMIT_SHA}}/${{ github.sha }}/g" sky/__init__.py
	sed -i "s/__version__ = '.*'/__version__ = '1.0.0-dev${RELEASE_VERSION}'/g" sky/__init__.py
	sed -i "s/name='skypilot',/name='skypilot-nightly',/g" sky/setup_files/setup.py

[Docker image] Nightly build of docker image #2229

[Docker image] Nightly build of docker image #2229

Conversation

PratikKumar125 commented Jul 13, 2023 • edited Loading

romilbhardwaj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Michaelvll commented Jul 14, 2023 • edited Loading

romilbhardwaj commented Jul 14, 2023

romilbhardwaj commented Jul 14, 2023

PratikKumar125 commented Jul 15, 2023

Michaelvll commented Jan 22, 2024

romilbhardwaj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PratikKumar125 commented Jul 13, 2023 •

edited

Loading

Michaelvll commented Jul 14, 2023 •

edited

Loading