Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pypi] Automatically release nightly version of skypilot #1446

Merged
merged 11 commits into from
Jul 14, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Nov 26, 2022

This will release the skypilot nightly to the https://pypi.org/project/skypilot-nightly/, so that the user can keep track of the nightly updates from SkyPilot, without cloning the GitHub repo.

TODO:

  • Add API key to the GitHub repo.

Tested:

@Michaelvll Michaelvll marked this pull request as draft November 26, 2022 05:11
@Michaelvll Michaelvll marked this pull request as ready for review November 26, 2022 17:50
@concretevitamin
Copy link
Member

Awesome! BTW, @dongreenberg mentioned that in order for a library they built that uses SkyPilot to be published on PyPI, they need to depend on a recent enough version (0.2.1 doesn't have the recent features they need). Sounds like we should seriously discuss nightly releases soon.

Comment on lines +43 to +45
sed -i "s/{{SKYPILOT_COMMIT_SHA}}/${{ github.sha }}/g" sky/__init__.py
sed -i "s/__version__ = '.*'/__version__ = '1.0.0-dev${RELEASE_VERSION}'/g" sky/__init__.py
sed -i "s/name='skypilot',/name='skypilot-nightly',/g" sky/setup_files/setup.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One reason I prefer to let the user use the nightly instead of the master branch is that we can then note the commit hash of the users in the dashboard.

@Michaelvll Michaelvll requested a review from romilbhardwaj July 13, 2023 16:11
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll!

@Michaelvll Michaelvll merged commit f35f65d into master Jul 14, 2023
@Michaelvll Michaelvll deleted the nightly-build branch July 14, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants