Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependency] Avoid buggy grpcio version #2055

Merged
merged 3 commits into from
Jun 9, 2023
Merged

[Dependency] Avoid buggy grpcio version #2055

merged 3 commits into from
Jun 9, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jun 9, 2023 •
edited
Loading

Fixes #2054

Tested (run the relevant ones):

  • Any manual or new tests for this PR (please specify below)
    • sky launch -c min --cloud gcp --cpus 2+ on the user's laptop
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

concretevitamin
concretevitamin approved these changes Jun 9, 2023
View reviewed changes
sky/setup_files/setup.py Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 72692a1 into master Jun 9, 2023
@Michaelvll Michaelvll deleted the avoid-buggy-grpcio branch June 9, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Ray failed to start dashboard when ray start is called by sky launch
2 participants
@Michaelvll @concretevitamin