Skip to content

Commit

Permalink
[Dependency] Avoid buggy grpcio version (#2055)
Browse files Browse the repository at this point in the history
* Avoid buggy grpcio version

* Add comment

* fix comment
  • Loading branch information
Michaelvll authored Jun 9, 2023
1 parent ed99fbe commit 72692a1
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions sky/setup_files/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,15 @@ def parse_readme(readme: str) -> str:
# we deprecate Python 3.7 (this will take a while).
"typing_extensions; python_version < '3.8'",
'filelock>=3.6.0',
# Adopted from ray's setup.py:
# Adopted from ray's setup.py: https://github.com/ray-project/ray/blob/ray-2.4.0/python/setup.py
# SkyPilot: != 1.48.0 is required to avoid the error where ray dashboard fails to start when
# ray start is called (#2054).
# Tracking issue: https://github.com/ray-project/ray/issues/30984
"grpcio >= 1.32.0, <= 1.49.1; python_version < '3.10' and sys_platform == 'darwin'", # noqa:E501
"grpcio >= 1.42.0, <= 1.49.1; python_version >= '3.10' and sys_platform == 'darwin'", # noqa:E501
"grpcio >= 1.32.0, <= 1.49.1, != 1.48.0; python_version < '3.10' and sys_platform == 'darwin'", # noqa:E501
"grpcio >= 1.42.0, <= 1.49.1, != 1.48.0; python_version >= '3.10' and sys_platform == 'darwin'", # noqa:E501
# Original issue: https://github.com/ray-project/ray/issues/33833
"grpcio >= 1.32.0, <= 1.51.3; python_version < '3.10' and sys_platform != 'darwin'", # noqa:E501
"grpcio >= 1.42.0, <= 1.51.3; python_version >= '3.10' and sys_platform != 'darwin'", # noqa:E501
"grpcio >= 1.32.0, <= 1.51.3, != 1.48.0; python_version < '3.10' and sys_platform != 'darwin'", # noqa:E501
"grpcio >= 1.42.0, <= 1.51.3, != 1.48.0; python_version >= '3.10' and sys_platform != 'darwin'", # noqa:E501
'packaging',
# Adopted from ray's setup.py:
# https://github.com/ray-project/ray/blob/86fab1764e618215d8131e8e5068f0d493c77023/python/setup.py#L326
Expand Down

0 comments on commit 72692a1

Please sign in to comment.