Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Fix azure launch #1619

Merged
merged 2 commits into from
Jan 24, 2023
Merged

[Azure] Fix azure launch #1619

merged 2 commits into from
Jan 24, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jan 24, 2023

This PR fixes a problem introduced by #1585, which assume the zones to be a list while it can be NoneType, causing the following error during pytest tests/test_smoke.py::test_azure_start_stop. This is another evidence for the importance of #1564 ; )

  File "/home/gcpuser/skypilot/sky/utils/common_utils.py", line 239, in _record
    return f(*args, **kwargs)
  File "/home/gcpuser/skypilot/sky/backends/cloud_vm_ray_backend.py", line 1637, in provision_with_retries
    config_dict = self._retry_region_zones(
  File "/home/gcpuser/skypilot/sky/backends/cloud_vm_ray_backend.py", line 1103, in _retry_region_zones
    for zone in zones:
TypeError: 'NoneType' object is not iterable
^[[31mFailed^[[0m.
Reason: sky start -y t-azure-start-stop-c884-b5
Log: less /tmp/azure-start-stop-3h69lw1t.log

Tested (run the relevant ones):

  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_azure_start_stop

@Michaelvll Michaelvll requested a review from WoosukKwon January 24, 2023 00:53
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Michaelvll for finding and fixing this bug.

@Michaelvll Michaelvll merged commit e6167b9 into master Jan 24, 2023
@Michaelvll Michaelvll deleted the fix-azure-zones branch January 24, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants