[core] Respect the block list when failover #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
reviewed
Jan 13, 2023
WoosukKwon
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Thanks @Michaelvll for fixing my bug! The code looks very good to me. Left only one minor comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1584
Tested (run the relevant ones):
sky launch --gpus A100:8 --cloud aws, correctly failover through the regions.sky launch --gpus A100:8 --use-spot --cloud aws, correctly failover through the zones.sky launch --instance-type m3-megamem-128failover correctly (skip the region after getting the information that the whole region does not have quota).sky launch --cloud azurefailover on Azure (make some change in theazure-ray.yml.j2to make the image invalid, to trigger the failover).pytest tests/test_smoke.py(with [Tests] Add options for test to select clouds #1587 merged)