Kotlin AWS sdk #424
Merged
Kotlin AWS sdk #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sksamuel any updates on when this might move past draft status? |
|
I can take a look at it next week again |
samu-developments
force-pushed
the
kotlin-aws-sdk
branch
from
afa0898 to
86e7523
Compare
…25, set only jvmToolchain languageVersion. Switch from java aws sdk to kotlin aws sdk
samu-developments
force-pushed
the
kotlin-aws-sdk
branch
from
86e7523 to
e32c990
Compare
|
Look at that, now the java sdk contains the env variable endpoint override. Anyway I rebased the branch and will make it ready for review. |
sksamuel
approved these changes
Nov 27, 2024
2.9.0 is now released ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a use case similar to this aws/aws-sdk-java-v2#4501 (comment); testing with Localstack and overriding AWS sdk endpoints using env variables. This is for some reason not supported in Java sdks, but it is in Kotlin sdks.
This PR is a copy of the
hoplite-awsmodule, with java aws sdk switched with kotlin sdk. Also updated kotlin version and updated some usage of version catalogs, gradle.I will have this as draft until this has feedback
Kotlin version needed to be updated for the newest Kotlin aws sdk to be compatible
> The binary version of its metadata is 1.9.0, expected version is 1.6.0.Also fixed kotlin test tasks needing jdk 11 (required by testcontainers).
> Inconsistent JVM-target compatibility detected for tasks 'compileTestJava' (11) and 'compileTestKotlin' (1.8).