-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom Json serde for SecretsManager #423
Merged
sksamuel
merged 8 commits into
sksamuel:master
from
samu-developments:sm-unquoted-numbers
Sep 16, 2024
Merged
Support custom Json serde for SecretsManager #423
sksamuel
merged 8 commits into
sksamuel:master
from
samu-developments:sm-unquoted-numbers
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix empty secret test to blank (SM (and localstack) does not support creating empty secret hashicorp/terraform-provider-aws#19731)
Merged
sksamuel
reviewed
Jul 30, 2024
hoplite-aws/src/main/kotlin/com/sksamuel/hoplite/aws/AwsSecretsManagerPreprocessor.kt
Outdated
Show resolved
Hide resolved
sksamuel
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
…e changes when upgrading
Couple of test failures. Will merge once green. |
Local tests were loading region from local config, works now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great library!
We had a use case where we needed to deserialize a json with a number value (not a quoted number string) from AWS secretsmanager, eg:
To do this one need to set the
isLenient
field to true inJson
builder:This PR adds
Json
as a constructor parameter toAwsSecretsManagerPreprocessor
to support custom json serde config. Let me know what you think.(In the end we just added our own custom preprocessor, which also works fine)