Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for infinite entries in spec files - default p_escape to 1.0 for low and high tau #98

Merged
merged 5 commits into from
Aug 11, 2014
Merged

Fix for infinite entries in spec files - default p_escape to 1.0 for low and high tau #98

merged 5 commits into from
Aug 11, 2014

Conversation

jhmatthews
Copy link
Collaborator

see #95

also includes new function p_escape_from_tau

@jhmatthews jhmatthews changed the title Fix for inifinite entries in spec files Fix for infinite entries in spec files - default p_escape to 1.0 for low and high tau Aug 8, 2014
@jhmatthews
Copy link
Collaborator Author

Changes here:

  • new function p_escape from tau which evaluates 1-exp(-tau)/tau, but with if statements to default to 1 for low tau and 1/tau for high tau.
  • sane_check for photon weight before extract, and error if p_norm is ever <= 0 in randwind_thermal_trapping()
  • Removed the NNSCAT_SAFETY buffer I was using for normalising p_norm. It complicates matters and I do not believe it is necessary.
  • added some comments

jhmatthews pushed a commit that referenced this pull request Aug 11, 2014
Merge pull request #98 from jhmatthews/inf_aniso_hotfix
67a69a6 
Fix for infinite entries in spec files - default p_escape to 1.0 for low and high tau
@jhmatthews jhmatthews merged commit 67a69a6 into sirocco-rt:dev Aug 11, 2014
@jhmatthews jhmatthews mentioned this pull request Aug 11, 2014
Closed
@jhmatthews jhmatthews deleted the inf_aniso_hotfix branch June 3, 2016 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jhmatthews