Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added errors for -ve rates, moved macro_pops call out of elements loop #75

Merged
merged 3 commits into from
Apr 14, 2014

Conversation

jhmatthews
Copy link
Collaborator

Some more robust errors and checks in macro_pops, and also a correction of a small error in saha.c which caused macro_pops to be called more times than necessary.

@jhmatthews
Copy link
Collaborator Author

Changes:

matom.c:

  • Errors reported if negative rates or populations are obtained in macro_pops
  • Added test to check that populations are solution to rate matrix equation in macro_pops

my_linalg.h:

  • Added the function declaration gsl_blas_dgemv. Couldn't use gsl/gsl_blas.h as was getting conflicting variables from the other functions.

These changes are all error reporting / diagnostic. No functional changes yet.

There will need to be some changes in how we clean levels for population inversions- e.g. only clean if there is a radiative transition between the level or similar, and we also need to work out how to implement collisional transitions to link the singlet and triplet states. Merging this, as that stuff requires more testing.

jhmatthews added a commit that referenced this pull request Apr 14, 2014
More robust errors and checking of populations in macro_pops
@jhmatthews jhmatthews merged commit 1fa52c4 into sirocco-rt:dev Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant