k-packet changes for free-free cooling #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes to deal with errors in how I'd coded the free-free cooling channel in kpkt(). The main changes are:
if the photon is less than the global minimum frequency, we discard the photon with an istate set to P_LOFREQ_FF, in the same way we do for adiabatic cooling.
IMPORTANT: There is still one outstanding caveat here, which is that I have to set kpkt_rates_known to -1 (i.e. not known) when restarting a run in the spectral cycles to avoid errors to do with kpkt destruction rates. It's not clear why this is, because once the model is converged the kpkt rates should be the same. It suggests a bug to me and should be investigated or discussed.
I'm opening the pull request now because this should be merged before southampton.