Use comoving frequency when calculating bound-free kpkt probability for simple atoms #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhmatthews Thre is at least one error in this that is causing a segfault with short_34.pf. It is in resonate. (This is in a different place than the "normal segfault" in mp mode)
You have not defined ndom in line 1011. |
|
Fixed that - did a force push to update (naughty). |
|
@jhmatthews I think you could merge this now. So far as I can tell this has "solved" that problem in the sense that errors are being trapped and the program continues onward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be good if someone could check this looks sensible; I haven't tested this at all yet @kslong @Higginbottom