New hydro code #178
Merged
New hydro code #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Higginbottom - so the reason for this failing build tests is that it doesn't compile with gcc, but does with mpicc. This is just because the `FILE *fptr, *fopen ();' line is inside an #ifdef so isn't declared without MPI_ON compiler flag (line 115 wind_updates2d.c). #ifdef MPI_ON
int num_mpi_cells, num_mpi_extra, position, ndo, n_mpi, num_comm, n_mpi2;
int size_of_commbuffer;
char *commbuffer;
FILE *fptr, *fopen ();could you fix and push? I presume that file ptr wants to be declared in all cases? |
|
Genius! |
|
Cool. I'm merging into dev via command line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set the groundwork for connecting python to zeus, plus some other housekeeping