Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communicate matom estimators between threads #135

Merged
merged 12 commits into from
Jan 16, 2015
Merged

Communicate matom estimators between threads #135

merged 12 commits into from
Jan 16, 2015

Conversation

jhmatthews
Copy link
Collaborator

This fixes #132 - see discussion and test results there.

  • New functions in para_update.c
  • int communicate_estimators_para(void) - moved communication of non-matom estimators from python.c to subroutine (checked produces identical results with fiducial model)
  • int gather_spectra_para(int nspec_helper, int nspecs) - moved averaging of spectra from python.c to subroutine
  • int communicate_matom_estimators_para(void) new function which averages matom estimators between threads, using MPI_Reduce and MPI_Bcast.

@jhmatthews
attempted to fix issue sirocco-rt#132 by gathering matom estimators i…
878acfa 
…n parallel mode
@jhmatthews
uncommented out call to communicate_matom_estimators_para and added s…
d5523a3 
…ome doc
@jhmatthews
fixed a conflict with version.h being in working tree
717177c
@jhmatthews
added cooling variables to macro atoms updating
bee53f6
@jhmatthews
corrected errors in array declaration
32deb70
@jhmatthews
added return 0 statement to communicate_matom_estimators_para when no…
a53c4eb 
… macro-atom levels. Question about the best thing to do here for simple-atoms
@jhmatthews
some extra commenting as well as corrected in error in call to gather…
a1242ae 
…_spectra_para
@jhmatthews
added some doc
65babd4
@jhmatthews
fixed errors for serial compilation with MPI_ON ifs
fbc9fe9
@jhmatthews
corrected helpers to use recieve arrays rather than send arrays
1749762
@jhmatthews
corrected typo in MPI reduce causing saegfaults on iridis
e81e87a
@jhmatthews
fixed merge conflict in python.c
155d852
@jhmatthews jhmatthews mentioned this pull request Jan 16, 2015
Closed
jhmatthews added a commit that referenced this pull request Jan 16, 2015
@jhmatthews
Merge pull request #135 from jhmatthews/para_estimator_fix
0e69acc 
Communicate matom estimators between threads
@jhmatthews jhmatthews merged commit 0e69acc into sirocco-rt:dev Jan 16, 2015
@jhmatthews jhmatthews deleted the para_estimator_fix branch June 3, 2016 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro-atom estimators not communicated between threads
1 participant
@jhmatthews