-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing advanced mode with -d flag to access #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into advanced_mode
…ata, added function to modes which controls whether to print out a summary of the atomic data to file, replaced a few other instances of #if DEBUG.
…does not include python.h
@kslong Knox- I'm inclined to control the use of Debug() with the verbosity tag instead of using the same as the advanced options. What do you think? |
Merging this- @kslong @Higginbottom @smangham see comment above for how to use- I will update other docs in due course |
jhmatthews
added a commit
that referenced
this pull request
Nov 7, 2014
Implementing advanced mode with -d flag to access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided in telecon and discussed in #111 we want an advance dusers mode which one accesses with -d. Using -d turns modes.iadvanced to 1.
Currently this asks for a few options which are not asked for if you don't run with -d. These are:
The variables for turning on modes are all in a global modes structure.
adjust_grid
allows one to turn adjust the scale lengths of the grid, asks for one or two options depending on type of grid used:
write_atomicdata(0=no,1=yes): write out a summary of atomic data, previously controlled with DEBUG
Extra.diagnostics(0=no,1=yes) - turns on extra diagnostics, and then looks for any of these options. Can give as many or as few as you want:
more can be added here. One just has to add a variable to the modes structure and adjust the function get_extra_diagnostics().
there's an example parameter file with everything in examples/sv_detailedmode.pf
Use of Debug() is controlled by the verbosity -v flag.
1: Only print Log_parallel
2,3: Log_parallel, Logs and Errors
4: Log_parallel, Logs, Debug and Errors
5: Log_silent, Error_silent, Log_parallel, Logs, Debug and Errors
it's not perfect so I'm open to suggestions on future improvements, but we need to try using it first.