Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence check for t_r is not working #577

Closed
kslong opened this issue Aug 7, 2019 · 2 comments
Closed

Convergence check for t_r is not working #577

kslong opened this issue Aug 7, 2019 · 2 comments

Comments

@kslong
Copy link
Collaborator

kslong commented Aug 7, 2019

In trying to look a bit more at questions associated with convergence, I find that t_r_old and t_r are always identical and hence all cells appear to be converged by that measure, even though t_r is clearly changing.

This may be a reappearance of #110

@kslong
Copy link
Collaborator Author

kslong commented Aug 7, 2019

Unlike #110 this problem does not go away in single processor mode. Looking back over regression tests for the last year, this problem has been their all along. Shame on us for not seeing it earlier.

The problem here is that t_r_old and t_r are identical when the check is made.

kslong added a commit that referenced this issue Aug 7, 2019
…d properly.

 Modifications to windsave2table to print out information about convergence
@kslong kslong closed this as completed in 2231c4f Aug 7, 2019
@kslong
Copy link
Collaborator Author

kslong commented Aug 7, 2019

As an explanation here. The reason one cannot treat t_r_old the same way one does t_e_old, is that t_e is updated in ionization c after all of the photons have been translated for the current cycle. So in ionization.c one can do the update. But t_r_old needs to be done immediately before t_r is calculated from the frequency distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant