-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photons absorbed in macro atom model of a dense CV wind #1024
Comments
This is part of a print out of some variables atter an ionization cycle. The lines labelled stat refer to status of photons after the transport, e.g escaped 2, absorbed = 6. What is reported is the number of photons, the final weight of those photons, and the initial weight of the photons. The lines labelled rad, refer to emitted photons. but here the numbers are associated with the origin (and whether they are macro atom photons are not. The main point of this is to show that the absorbed photons actually represent a large fraction of the total luminosity of the system.
|
The problem is occurring here
The problem can be avoided by turning off "upweighting", which here is downweighting photons regularly. |
The "upweigthing" for bf is carried out a few lines earlier in the code.
As written it always reduces the photon weight. How is the energy supposed to come out @jhmatthews |
See the docs here: https://agnwinds.readthedocs.io/en/dev/physics/macroatoms.html?highlight=upweight#bound-free-continua-of-simple-atoms - there's another place where we upweight. Note also that we record and report the amount of energy being extracted/deposited in the bound-free simple ion pool. I think the two bits of code are in kpkt() and scatter() -- although one of the comments is a bit confusing there and seems to have got mixed up. |
@jhmatthews The situation described in Readthedocs is not what is happening. In this case, the problem is that the photons are being downweighted so much from multiple scatterings that they eventually count as absorbed. Note that I have tried Christian's suggestion for running a model to convergence (75%) without upweighting, and then running another cycle with it on. While we don't loose 50% of the flux as we do when you run with upweighting on, we do lose 25%, which I think should be concerning (even if we make not upweighting the default.) Is there anywhere that we have a full description of how this is all supposed to work; the readthedocs page really does not explain this anywhere. If this does not exist, it would be extremely useful if one were created. |
I posted the Readthedocs page because you asked above how the energy is supposed to come out, not because it explains this issue which has only just come up in this particular form. The cautionary note about numerical problems is indeed a different issue (although related). In terms of how all this is supposed to work, the description on RtD, whilst doubtless flawed, is my best attempt to explain that. Perhaps there are some things missing but I can't think what exactly. |
There was a suggestion made by @ssim that this problem might be due to the fact that we do not use the Milne relation to calculate recombination rates might result in the problem we are seing, because the recombination rates might be higher than predicted. In that case, one might eliminate the problm if we used the Milne relation instead. @jhmatthews suggested we could test this by removing the separate recombination rates from the program. So I modified the data file we have been using h20_hetop_standard80.dat, removing these lines The logs say that the Milne relation is being used, so presumably this is a good test of this hypothesis. |
We document the flow of energy in the log files for the entire wind. For the original model and the one which is supposed to follow the Milne relation this is what one gets:
In this case the energy in is typically 10 x the energy out. Note there is one line for each of the 20 cycles BUT if one runs a macro atom model, without any macro atoms you get something quite different
The totals are higher now, and there is variability. But in this case the energy in is equal to the energy out. @jhmatthews @ssim Is this expected? Is it possible that something is wrong when a simple atom is photoionized but a macro atom is selected for recombination. |
@jhmatthews On branch bug1024_lost, I added more tracking of what bf process are doing. The file shows (I think) what fb process have absorption and emission. The first column is the fb no, the second is the elment involved, the third is the ion state and the 4th and 5 columns are the number of times one absorbed by that fb process and the number of decays by that process. Some of it makes sense, we see lots of re-combinations to H and He. What does not make sense is the huge number of interactions with NV and OVI, since both are almost absent in the wind. |
I agree that's confusing. I guess it's possible that there are some sizable minority of cells where there is a decent amount of NV and OVI, since I think this file is a cumulative one across the whole wind? It's not clear to me exactly what we mean here by "number of times one is absorbed by fb process" i.e. whether it means r-packet activations of a simple-atom via that bound-free process? If so, the chance of it happening is set just by the bound-free opacity, I think. The post before about macro-atoms is less surprising to me, because removing the macro-atom data is changing how the H and He continua are treated, so I might well expect the problem to increase (the downweighting can also take place in the H and He continua if they are treated as simple ions, rather than being done "self consistently" within the macro-atom). |
The numbers here are, as James guessed the total for the wind, but as far as I can tell the OVI and NV concentrations are very very small. If one does a diff between the bug1024_lost branch, it is easy to see where I did the counting. I guess my question about the difference between results with and without macro atoms is for the H and He macro atom case, do these create a situation where necessarily we are creating an imbalance. Photons that undergo bound free absorption necessarily lose the ionization energy, but when they come back through a macro atom recombination, they may not get it back. I know the upweighting which occurs early is expected to compensate for that, but it does not seem to. |
Well, my previous comment was incorrect. Indeed OVI and NV are the dominant versions of these species, as the disk in this model is very hot 10**5 K. So it rather looks like the following is happening. BF transitions are dominated by ionization of ions like NV and OVI, but they are recombining mainly into H and He. Photons are losing ionization energy when they are absorbed, but the boosting that occurs is insufficient to make up for the energy that they lose. The question that needs answering it seems to me now is why the upweighting does not, on average at least, balance this all out. |
Hi - maybe we can discuss more if we all talk later. But it sounds like what we're getting is that photoionzation is mainly absorbing photons via the metals, but recombination is mainly going through hydrogen and helium? If that's true as a statement about photons then it must mean that there's an inconsistency between the actual ion populations and the rates of photon destruction / emission somewhere.
Do we know if this issue occurs if we don't include any metals at all? I.e. if we use only H+He macro atoms (and nothing else) does the same problem occur? Or is this some interplay between the two.
One thing that comes to mind is that we probably do expect to lose energy in a scheme with the upweighting by ionisation energy - because that ignores any energy that comes via the radiative bound bound cascade in 'simple' atoms.
On 3 Oct 2023, at 22:17, Knox S. Long ***@***.***> wrote:
This message is from an external sender. Please take care when responding, clicking links or opening attachments.
Well, my previous comment was incorrect. Indeed OVI and NV are the dominant versions of these species, as the disk in this model is very hot 10**5 K. So it rather looks like the following is happening. BF transitions are dominated by ionization of ions like NV and OVI, but they are recombining mainly into H and He. Photons are losing ionization energy when they are absorbed, but the boosting that occurs is insufficient to make up for the energy that they lose.
The question that needs answering it seems to me now is why the upweighting does not, on average at least, balance this all out.
—
Reply to this email directly, view it on GitHub<https://github.com/agnwinds/python/issues/1024#issuecomment-1745739439>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAGA6LNHCI65T2WQ3BF2EVDX5R6E7AVCNFSM6AAAAAA5FFBMPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVG4ZTSNBTHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
* Provides additional diagnostics of energy flow into and out of the ion pool (see #1024) * Version changed to 87f due to the fact that there are additional variables in the plasma structure * There should be no actual changes to the way photons are processed.
Photons are not normally supposed to be absorbed in macro atom models, and yet in a dense CV wind that is exactly what is happening. These photons are being reported as absorbed and in 87d they appear carry a small amount of energy, but in fact the value that is being reported is not the original energy but the the final energy carried by the photons that is being reported.
foo.pf.txt
The text was updated successfully, but these errors were encountered: