Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier, set up CI #85

Merged
merged 5 commits into from
Nov 30, 2024
Merged

Add Prettier, set up CI #85

merged 5 commits into from
Nov 30, 2024

Conversation

psvenk
Copy link
Member

@psvenk psvenk commented Nov 30, 2024

Fixes #54. ESLint is already configured with create-react-app, so this just adds a script for running Prettier and sets up CI for Prettier, ESLint, and Black.

@psvenk psvenk force-pushed the prettier branch 3 times, most recently from 5389862 to 51c4aeb Compare November 30, 2024 19:26
@psvenk psvenk marked this pull request as ready for review November 30, 2024 19:57
@psvenk psvenk mentioned this pull request Nov 30, 2024
Copy link
Member

@cjquines cjquines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for black, we either have to add instructions on how to run black, or maintainers need to commit to running it against PRs when someone submits something unformatted

@psvenk psvenk merged commit c062692 into main Nov 30, 2024
3 checks passed
@psvenk psvenk deleted the prettier branch November 30, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up a linter (with CI?) for the backend/frontend
2 participants