Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up a linter (with CI?) for the backend/frontend #54

Closed
Alwinfy opened this issue Sep 21, 2023 · 1 comment · Fixed by #85
Closed

Set up a linter (with CI?) for the backend/frontend #54

Alwinfy opened this issue Sep 21, 2023 · 1 comment · Fixed by #85
Assignees
@psvenk
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Alwinfy
Copy link
Collaborator

Alwinfy commented Sep 21, 2023 •
edited
Loading

Probably want to use ESLint and Prettier for the frontend and something like Black for the backend.

Note: Do not try to use ESLint's indent directly, it's busted! See here.
@Alwinfy Alwinfy added enhancement New feature or request good first issue Good for newcomers labels Sep 21, 2023
@Haile-08
Copy link

Haile-08 commented Sep 21, 2023 •
edited
Loading

can u assign me this task?

This was referenced Sep 21, 2023
Merged
Closed
@cjquines cjquines mentioned this issue Nov 30, 2024
Merged
@psvenk psvenk assigned psvenk and unassigned Haile-08 Nov 30, 2024
@psvenk psvenk mentioned this issue Nov 30, 2024
Merged
psvenk added a commit that referenced this issue Nov 30, 2024
@psvenk
Add Prettier, set up CI (#85)
c062692 
Fixes #54. ESLint is already configured with create-react-app, so this
just adds a script for running Prettier and sets up CI for Prettier,
ESLint, and Black.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psvenk psvenk

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Prettier, set up CI sipb/hydrant
3 participants
@Alwinfy @psvenk @Haile-08