Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR)
closes #1814 by reverting changes introduced in #1807
Background
#1807 started using lolex 2.7 (up from 2.4.2). The regular tests pass, but as the cloud tests running against our suite of browsers only run on merge to
master
it only became apparent that it broke Safari 9 after the fact. We might try again once sinonjs/fake-timers#190 has been closed.How to verify - mandatory
export SAUCE_USERNAME=sinonjs
export SAUCE_ACCESS_KEY=<secret>
npm run test-cloud