Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #1807 to fix #1814 #1818

Merged
merged 1 commit into from
May 31, 2018
Merged

Revert PR #1807 to fix #1814 #1818

merged 1 commit into from
May 31, 2018

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented May 31, 2018

Purpose (TL;DR)

closes #1814 by reverting changes introduced in #1807

Background

#1807 started using lolex 2.7 (up from 2.4.2). The regular tests pass, but as the cloud tests running against our suite of browsers only run on merge to master it only became apparent that it broke Safari 9 after the fact. We might try again once sinonjs/fake-timers#190 has been closed.

How to verify - mandatory

  1. export SAUCE_USERNAME=sinonjs
  2. export SAUCE_ACCESS_KEY=<secret>
  3. npm run test-cloud

@fatso83 fatso83 merged commit bed477a into sinonjs:master May 31, 2018
@fatso83 fatso83 deleted the revert-deps branch May 31, 2018 08:09
@fatso83
Copy link
Contributor Author

fatso83 commented May 31, 2018

Well, that fixed the Safari issues, but we still have some issues with IE 11! @mroderick

  1) fake
       .resolves
         should return a function that resolves to the argument:
     ReferenceError: 'Promise' is undefined
      at f (lib/sinon/fake.js:82)
      at fakeInstance (lib/sinon/fake.js:46)
      at invoke (lib/sinon/spy.js:209)
      at proxy (lib/sinon/spy.js:95)
      at Anonymous function (test/fake-test.js:190)

  2) fake
       .rejects
         should return a function that rejects to the argument:
     ReferenceError: 'Promise' is undefined
      at f (lib/sinon/fake.js:90)
      at fakeInstance (lib/sinon/fake.js:46)
      at invoke (lib/sinon/spy.js:209)
      at proxy (lib/sinon/spy.js:95)
      at Anonymous function (test/fake-test.js:203)

  3) fake
       .rejects
         should return the same error type as it is passed:
     ReferenceError: 'Promise' is undefined
      at f (lib/sinon/fake.js:90)
      at fakeInstance (lib/sinon/fake.js:46)
      at invoke (lib/sinon/spy.js:209)
      at proxy (lib/sinon/spy.js:95)
      at Anonymous function (test/fake-test.js:214)

  4) fake
       .rejects
         when passed a String
           should reject with an Error:
     ReferenceError: 'Promise' is undefined
      at f (lib/sinon/fake.js:90)
      at fakeInstance (lib/sinon/fake.js:46)
      at invoke (lib/sinon/spy.js:209)
      at proxy (lib/sinon/spy.js:95)
      at Anonymous function (test/fake-test.js:224)


@benjamingr
Copy link
Member

Looks like either a promise polyfill or a guard around APIs using promises in environments that don't ship them natively is missing @fatso83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression introduced in #1807
3 participants