Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression introduced in #1807 #1814

Closed
fatso83 opened this issue May 29, 2018 · 7 comments · Fixed by #1818
Closed

Regression introduced in #1807 #1814

fatso83 opened this issue May 29, 2018 · 7 comments · Fixed by #1818

Comments

@fatso83
Copy link
Contributor

fatso83 commented May 29, 2018 •
edited
Loading

The simple PR #1807 to update the dependencies broke the build for master.

Both IE11 and Safari has problems as of (IE11 Promise related, Safari faking time). Not sure why or what caused it, but lolex is a reasonable guess when it comes to Safari.

We could simply revert the PR, but it should be possible to find the regression in the list of dependencies.
@fatso83 fatso83 changed the title Regression introduced for IE11 in #1807 Regression introduced in #1807 May 29, 2018
@fatso83
Copy link
Contributor Author

fatso83 commented May 29, 2018

Installing lolex 2.4.2 fixes the Safari issue.

@fatso83
Copy link
Contributor Author

fatso83 commented May 29, 2018 •
edited
Loading

I added Safari 9 to the list of browsers now. The regression was introduced in sinonjs/fake-timers#169. Seems like Safari doesn't handle that quite right. Ping @SimenB

fatso83 added a commit to sinonjs/fake-timers that referenced this issue May 29, 2018
@fatso83
Add Safari 9 to list of Sauce Labs browsers
8a30ce6 
Is on the list of supported browsers in Sinon.
Affected by change in #176.

See  sinonjs/sinon#1814
@fatso83
Copy link
Contributor Author

fatso83 commented May 29, 2018 •
edited
Loading

@sinonjs/core this is what is breaking the build. We could install lolex 2.4 or fix 2.7 (or both)

@SimenB
Copy link
Member

SimenB commented May 30, 2018 •
edited
Loading

sinonjs/fake-timers#176 doesn't make sense... Which one did you mean?

EDIT: Did you mean sinonjs/fake-timers#169?

@fatso83
Copy link
Contributor Author

fatso83 commented May 30, 2018 •
edited
Loading

Yes, that's the one. it was late in the night ;)

This was referenced May 30, 2018
Closed
Closed
@benjamingr
Copy link
Member

Mind explaining why the JSDOM integration test was causing this issue? I'm not sure I understand.

@fatso83
Copy link
Contributor Author

fatso83 commented May 30, 2018 via email

fatso83 added a commit to fatso83/sinon that referenced this issue May 31, 2018
@fatso83
Revert PR sinonjs#1807 to fix sinonjs#1814
998e45b 
closes sinonjs#1814
This was referenced May 31, 2018
Closed
Merged
fatso83 added a commit that referenced this issue May 31, 2018
@fatso83
Revert PR #1807 to fix #1814
bed477a 
closes #1814
franck-romano pushed a commit to franck-romano/sinon that referenced this issue Oct 1, 2019
@fatso83
Revert PR sinonjs#1807 to fix sinonjs#1814
debf7ce 
closes sinonjs#1814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert PR #1807 to fix #1814 fatso83/sinon
3 participants
@fatso83 @benjamingr @SimenB