-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Column abstraction: SOMAGeometryColumn
, part 3
#3427
Conversation
SOMAGeometryColumn
, part 3SOMAGeometryColumn
, part 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XanthosXanthopoulos thanks for working on this! The split-up makes this PR much easier to review.
fc53e6e
to
497224a
Compare
73865cb
to
5bcd88d
Compare
497224a
to
e02f78e
Compare
b0a1976
to
3faefd9
Compare
e02f78e
to
6f4d6a2
Compare
6f4d6a2
to
8daf17e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3427 +/- ##
==========================================
+ Coverage 86.25% 86.30% +0.04%
==========================================
Files 55 55
Lines 6359 6359
==========================================
+ Hits 5485 5488 +3
+ Misses 874 871 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saying either 'core domain', 'core current domain', 'soma domain', or 'soma maxdomain' is absoutely crucial for avoiding confusion. Saying 'domain' might mean any one of these four, and so it ambiguous. I requested these changes the last time; I'm still requesting them this time.
I know the names are confusing and that's why we must be absolutely vigilant to help out our co-workers, in the present and in the future, by being very clear.
…nt domain checks, replace vector with span when selecting points
…nt domain checks, replace vector with span when selecting points
…nt domain checks, replace vector with span when selecting points
8daf17e
to
a426c7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @XanthosXanthopoulos !
This PR introduces the
SOMAGeometryColumn
concrete class that implement a spatial index WKB (Well-Known Binary) column. A set of internal TileDB dimensions are used to provide the index mechanics as well as a TileDB Attribute to hold the geometry data encoded in a WKB blob.